fix: update error hints to reference subdir after path→subdir rename#46
Merged
Conversation
The hints in fetcher and hasher still told users to check a mistyped `path` in the manifest, but the field was renamed to `subdir` in #31. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
PR Summary by QodoFix stale error hints:
AI Description
High-Level Assessment
Files changed (2)
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require review |
Codecov flagged the post-checkout "not a directory" branch as the only uncovered line of the patch; exercise it with a subdir that points at a blob, which passes the ls-tree existence check. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
min0625
force-pushed
the
fix/stale-path-hint
branch
from
ace0582 to
c29bdcf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three user-facing error hints still told users to check a mistyped
pathin the manifest, but the field was renamed tosubdirin #31. Users following the hint would look for a key that no longer exists.internal/fetcher/fetcher.go(two occurrences)internal/hasher/hasher.go(one occurrence)No golden files or docs contain the old wording, so this is a message-only change.
🤖 Generated with Claude Code